lila icon indicating copy to clipboard operation
lila copied to clipboard

Link accuracy explanation on analysis report

Open benediktwerner opened this issue 2 years ago • 3 comments

Explanation page: lichess.org/page/accuracy

image

Maybe just link the "accuracy" text though ig it would need some nicer styling since the link-blue would clash. Maybe just a dotted underline or make the link a question mark after the text.

benediktwerner avatar Sep 17 '22 16:09 benediktwerner

I'll try my hand at this. I just need to find out where the code generates these and it should be a quick fix!

tleadon avatar Sep 22 '22 00:09 tleadon

I'll try my hand at this. I just need to find out where the code generates these and it should be a quick fix!

I think I found where it is. And now, I have to figure out how scala is generating the html lol

tleadon avatar Sep 22 '22 00:09 tleadon

Okay I figured out that h in import { h, thunk, VNode } from 'snabbdom'; makes the html tags... whatever snabbom is Lol

tleadon avatar Sep 22 '22 00:09 tleadon

I see that this issue is not close yet, could I give it a try?

BaoAn21 avatar Oct 04 '22 02:10 BaoAn21

#11665 this is my pull request

BaoAn21 avatar Oct 04 '22 06:10 BaoAn21

my first PR ever :)), thank you

BaoAn21 avatar Oct 06 '22 01:10 BaoAn21