lila icon indicating copy to clipboard operation
lila copied to clipboard

Board highlights red-green colorblind

Open ddugovic opened this issue 2 years ago • 4 comments

Exact URL where the bug happened https://lichess.org/analysis or any URL with a game board

Steps to reproduce the bug

  1. Highlight squares using green and red circles

What did you expect to happen? Color-blind people can differentiate between the red and green colors. (Probably there is the same issue with red and green arrows.)

What happened instead? Color-blind player thinks both circles are the same color. So if a livestreamer or study author were to try to explain a point based upon red circles and green circles, color-blind players wouldn't understand that point.

Operating system and browser version MS Edge (latest) or any Chromium-based browser

image

ddugovic avatar Jan 20 '22 03:01 ddugovic

Do you know what file path I could potentially find the code for the circles? Is it controled by an image thats displayed on the board or is the cirlce drawn by the program?

This is my first issue within this codebase. Sorry for the basic questions.

willmccarten avatar Jan 21 '22 22:01 willmccarten

It's in chessground: https://github.com/ornicar/chessground/blob/master/src/state.ts#L173

Though this doesn't really seem like an easy and obvious first issue? How are you planning on fixing this? I don't think changing the colors to something other than green and blue is a solution. Maybe changing the shade could help but that seems highly individual so also not really like a proper solution.

benediktwerner avatar Jan 22 '22 03:01 benediktwerner

I now made a pull request with changing the contrast between red and green, but also green and blue. Let's see if it is accepted

https://github.com/lichess-org/chessground/pull/226

Rabergsel avatar Jun 09 '22 10:06 Rabergsel

It would be nice to have a palette of more colors for presentation purposes, say red, green, blue, purple, etc

jxu avatar Jul 28 '22 00:07 jxu