lichobile icon indicating copy to clipboard operation
lichobile copied to clipboard

allow user TV open in app

Open valvin1 opened this issue 3 years ago • 3 comments

When I want to watch a user TV by clicking on a link it is not opening in the app (Android on my case but it should be the same with other OS).

So if I click on https://lichess.org/@/valvin1/tv browser offers me only browser apps to view this page althought it is implemented in the app.

I add a quick look on Android side and it looks it requires adding url pattern here: https://github.com/lichess-org/lichobile/blob/master/android/app/src/main/AndroidManifest.xml#L40

Wondering if it could be an easy quick win :)

valvin1 avatar Apr 08 '22 21:04 valvin1

Hello! I'd like to pick up this issue, but its strange. "/tv" is already included in the URL patterns in the manifest file. Where else would one look to address this issue?

tleadon avatar Sep 21 '22 22:09 tleadon

Excellent! The path prefix is relative to lichess.org - so lichess.org/tv will be picked up by the app, whereas lichess.org/@/username/tv won't. (Yet!) You'll probably have to add a pathPattern to that manifest

jas14 avatar Sep 21 '22 23:09 jas14

Ohhhhh! That makes sense! I'll get right on that!

tleadon avatar Sep 21 '22 23:09 tleadon