lichobile icon indicating copy to clipboard operation
lichobile copied to clipboard

Timer should show move time when cycling through moved

Open rajsinghUSA opened this issue 4 years ago • 4 comments

As you go forward and back through the move history (whether during or after a game), the clock should show the appropriate remaining time corresponding to when the move was made.

rajsinghUSA avatar Oct 31 '20 14:10 rajsinghUSA

FYI @rajsinghUSA the analysis board already shows times: https://github.com/veloce/lichobile/issues/941

jas14 avatar Nov 02 '20 21:11 jas14

Hi, yes I'm aware about the analysis board. I am referring to the game board both during and after the game.

rajsinghUSA avatar Nov 02 '20 22:11 rajsinghUSA

Some questions:

  • When viewing the latest move, i.e. following the game in real time - whether you are spectating or playing - I think we can agree that the clock should show the real remaining time.
  • When viewing a game that has ended, should the clock show the remaining time at the end of the game, or the time remaining at the viewed move?
  • When playing or viewing a live game, should the clock show the actual remaining time, or the time remaining at the viewed move?

This last point is tricky - a spectator and a player may want to see different things on the clock. It could get somewhat confusing if the behavior of the clock changes based on 1) if you are a player or spectator, 2) if the game has ended or not, and 3) if you are viewing the most recent move or a previous move.

What are you envisioning?

jas14 avatar Nov 03 '20 21:11 jas14

@jas14 Easiest way to explain is to check out how BabasChess does it on FICS.

rajsinghUSA avatar Sep 17 '22 13:09 rajsinghUSA

Point 1 -- agreed @jas14

Re: Point 2

When viewing a game that has ended, should the clock show the remaining time at the end of the game, or the time remaining at the viewed move?

I would say that the clock should update to the time remaining at the viewed move while navigating ONLY for games that have ended.

Point 3 -> agreed. The clock shouldn't update when viewing a live game.

But having said all of this, I also kind of agree that since that component's behaviour is changing based on whether a game is live or ended, it does violate the single responsibility principle of SOLID and can become confusing UX. Should there be a new component where we show the remaining time at the viewed move? or maybe a way to toggle between the two.

vishalsatam avatar Oct 03 '22 23:10 vishalsatam

This feature would be very nice to have.

Deleplace avatar Nov 28 '22 10:11 Deleplace