api icon indicating copy to clipboard operation
api copied to clipboard

Message not sent when calling api/bulk-pairing

Open 6heads opened this issue 4 years ago • 2 comments

As far as I understood it, a message should've been send when the api returns 200.

I successfully setup a pairing, but none of the players received a message. Did I understood something wrong? Or does the creator don't receive messages? My other test accounts were restricted to kids mode, so they won't receive a message. How are those supposed to play/join? Wouldn't a notification be better?

Another question regarding the documentation to messages. It says: {opponent} and {game} are placeholders that will be replaced with the opponent and the game URLs. Are there any other placeholders like {player}?

6heads avatar Apr 03 '21 00:04 6heads

I just tried and the players do receive the message, whether they're kid accounts or not.

http post http://l.org/api/bulk-pairing 'Authorization: Bearer 20cqYz68bqDNUnb1' clock.limit=300 clock.increment=0 players=Q8enJjgd1yZdm7tN:KYOBI3UASykqkIxn

Maybe give more details to help me reproduce the problem? I'm responsive in the discord API channel

ornicar avatar Apr 07 '21 18:04 ornicar

As I wrote on discord I didn't get a notification/message when I put the date close to the max of +24 hours. Maybe the message is sent a few hours before the start of the game?

But there is more. If one player is a child, the adult will receive a notification, but no message. The kid won't receive anything. You told me that this is to protect the kids. For the kids side this is reasonable, but why not sending a message to the adult? The game will start nonetheless so it doesn't make a difference if you join via message or lobby.

Imo bulk pairings are more or less the same as challenges and as an adult you can challenge a child if you wish. Maybe it would be nice to have a notification on the challenge-symbol when the game is about to start? This way even kids could join.

A slightly modified waiting screen would be nice - if I had a wish: image

6heads avatar Apr 07 '21 20:04 6heads

Bulk pairings got a lot of updates in the past few months. Closing for now. If there's still a problem, you can open another issue in the lila repo.

fitztrev avatar Mar 29 '24 14:03 fitztrev