libuv icon indicating copy to clipboard operation
libuv copied to clipboard

unix: re-allow WRONLY fd in uv_read_start

Open fantix opened this issue 5 years ago • 4 comments

For the writing end (O_WRONLY) of a pipe(2), we should also allow polling for read, so that the user could listen for a broken pipe on the writing end using uv_read_start() without having to try to write anything to the pipe, or wait until the next write to find out.

Fixes: https://github.com/libuv/libuv/issues/2058

fantix avatar Dec 01 '20 04:12 fantix

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 23 '20 03:12 stale[bot]

@santigimeno a gentle reminder that the requested changes are committed, thanks for re-checking!

fantix avatar Feb 05 '21 05:02 fantix

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/2120/

santigimeno avatar Feb 05 '21 09:02 santigimeno

@santigimeno Thank you! I believe now the failing tests are fixed.

fantix avatar Feb 07 '21 18:02 fantix