hidapi icon indicating copy to clipboard operation
hidapi copied to clipboard

Warnings

Open Sod-Almighty opened this issue 1 year ago • 3 comments

Warnings are errors, people!

linux/hidapi/hid.c:23: warning: "_GNU_SOURCE" redefined
   23 | #define _GNU_SOURCE /* needed for wcsdup() before glibc 2.10 */
      |
<command-line>: note: this is the location of the previous definition
linux/hidapi/hid.c: In function ‘void read_callback(libusb_transfer*)’:
linux/hidapi/hid.c:953:37: error: invalid conversion from ‘void*’ to ‘hid_device*’ {aka ‘hid_device_*’} [-fpermissive]
  953 |         hid_device *dev = transfer->user_data;
      |                           ~~~~~~~~~~^~~~~~~~~
      |                                     |
      |                                     void*
linux/hidapi/hid.c: In function ‘void* read_thread(void*)’:
linux/hidapi/hid.c:1022:27: error: invalid conversion from ‘void*’ to ‘hid_device*’ {aka ‘hid_device_*’} [-fpermissive]
 1022 |         hid_device *dev = param;
      |                           ^~~~~
      |                           |
      |                           void*
linux/hidapi/hid.c: In function ‘void cleanup_mutex(void*)’:
linux/hidapi/hid.c:1480:27: error: invalid conversion from ‘void*’ to ‘hid_device*’ {aka ‘hid_device_*’} [-fpermissive]
 1480 |         hid_device *dev = param;
      |                           ^~~~~
      |                           |
      |                           void*

Sod-Almighty avatar Mar 24 '24 17:03 Sod-Almighty

PRs with fixes are welcome.

Youw avatar Mar 25 '24 14:03 Youw

And that mentality is exactly what is wrong with open source. Take no responsibility for the quality of your work, and when someone reports a problem, tell them to feel free to fix it.

When someone reports a problem with my software, I fix it. Because I have pride in my work.

Sod-Almighty avatar Mar 25 '24 14:03 Sod-Almighty

Because I have pride in my work.

And complete disrespect of other people's time and efforts.


I really appreciate reporting the problem - clearly our CI needs some improvements, I expected it should have caught it.

When someone reports a problem with my software

In order to support 10% of software I wrote at some point, I had to hire a team of 6 people. If you're claiming you can support and fix all of the software you've ever written - it is either not much, or not much people is using it.

Youw avatar Mar 25 '24 14:03 Youw