hidapi icon indicating copy to clipboard operation
hidapi copied to clipboard

libusb: stop `read_thread` from looping indefinitely (#456)

Open thesilvanator opened this issue 3 years ago • 3 comments

  • When libusb_submit_transfer in read_thread fails, read_callback never gets called and never sets transfer_loop_finished to true, causing read_thread to loop indefinitely.

  • Fix this by skipping the handle_events for the transfer

  • Fixes #456

thesilvanator avatar Sep 13 '22 19:09 thesilvanator

I see that you have approved this, but the one of the CI checks seems to be still waiting for completion. Is there anything I can do to fix this?

thesilvanator avatar Sep 14 '22 17:09 thesilvanator

No worries, that is not a blocker.

Youw avatar Sep 14 '22 18:09 Youw

Ah, ok. So when does this eventually get merged in?

thesilvanator avatar Sep 18 '22 18:09 thesilvanator