libsndfile icon indicating copy to clipboard operation
libsndfile copied to clipboard

Preliminary wavpack support

Open tuxzz opened this issue 5 years ago • 6 comments

Preliminary implementation of Issue #15.

I only know a little subset of libsndfile and wavpack, so this implementation is very preliminary. It just works on common cases.

Please make suggestion for anything I can improve.

tuxzz avatar Nov 30 '20 16:11 tuxzz

Cool! I'll do a review as soon as I'm a little more free.

evpobr avatar Nov 30 '20 16:11 evpobr

I now use this branch and it works well for my use case (with a 19 channel file); I can seek anywhere in a very large file (more than 30G) almost instantly. It'd be nice to complete the integration of WavPack to libsndfile, with the collaboration of the main developers of libsndfile and WavPack. There's probably things to fix like the limit of 31 channels (which makes no sense to me). Thanks a lot to tuxzz, and I hope that WavPack will find its way into the official release of libsndfile.

marclava avatar Jun 20 '21 13:06 marclava

I think this can be merged since there is no obvious bug. I have no much free time recently so the limit of 31 channels may be fixed later, but not now. The current version should cover most use cases.

tuxzz avatar May 04 '22 05:05 tuxzz

On my own, I will add that we have not forgotten about this PR :smile:

Unfortunately, I'm very busy at work right now.

evpobr avatar May 04 '22 10:05 evpobr

I have no much free time recently so the limit of 31 channels may be fixed later, but not now.

WavPack don't have a limit on the number of channels, so if a limit must be provided (to libsndfile), set it to a high value (256 or more). It will work.

marclava avatar May 04 '22 12:05 marclava

Hi again. I need WavPack support for libsndfile; can I expect it to be merged? Until then I can maintain my own version but it'd be sub-optimal. Thanks.

marclava avatar Apr 20 '23 13:04 marclava