SDL_net icon indicating copy to clipboard operation
SDL_net copied to clipboard

Restore support for building with Winsock 1.1 (SDL 1.2)

Open ccawley2011 opened this issue 2 years ago • 6 comments

ccawley2011 avatar Jan 30 '22 15:01 ccawley2011

Why do we truly need this?

sezero avatar Jan 30 '22 15:01 sezero

I mean, the windows version relies on iphlpapi.dll even in the SDL-1.2 branch which isn't available (at least by default as far as I know) on w9x/nt4, so we certainly shouldn't care about winsock-1.x.

Closing. @slouken, @icculus: reopen and/or merge this if you disagree.

sezero avatar Jan 30 '22 16:01 sezero

Why do we truly need this?

This is needed to support Windows 95 without the Winsock 2 upgrade installed.

I mean, the windows version relies on iphlpapi.dll even in the SDL-1.2 branch which isn't available (at least by default as far as I know) on w9x/nt4, so we certainly shouldn't care about winsock-1.x.

iphlpapi.dll is included with newer versions of Internet Explorer (which doesn't guarantee the existence of the Winsock 2 upgrade). In a Winsock 2 build, it'll be necessary to replace GetAdaptersInfo for UWP builds anyway (see issue #30), and while it would still be necessary to have GetAdaptersInfo in Winsock 1 builds, it would be better to address it in a separate PR.

ccawley2011 avatar Jan 30 '22 16:01 ccawley2011

OK then, leaving decision to @slouken and/or @icculus

sezero avatar Jan 30 '22 16:01 sezero

If this gets accepted though, note that one issue is this: https://github.com/libsdl-org/SDL_net/issues/26 (original report at https://github.com/mxe/mxe/issues/550), i.e.: iphlpapi.h needing ws2tcpip.h with some SDKs.

sezero avatar Jan 30 '22 18:01 sezero

We don't officially support Windows 95, but I think this is harmless. @ccawley2011, can you fix this PR so you don't reintroduce #26?

slouken avatar Jun 16 '22 00:06 slouken