SDL icon indicating copy to clipboard operation
SDL copied to clipboard

Can no longer create a borderless window on macOS

Open a-hurst opened this issue 3 years ago • 1 comments

Hi there,

Just caught what I'm pretty sure is a legitimate bug/regression in the latest SDL2 release (2.24.0): on macOS (and only macOS), if you create a window with the SDL_WINDOW_BORDERLESS flag and then immediately check its flags with SDL_GetWindowFlags(window), it doesn't report being borderless. If you set the window to be borderless with SDL_SetWindowBordered after creating it that works fine, but creating it in a borderless state doesn't.

To try and bisect the bug, I tried the SDL 2.23.2 macOS pre-release binaries and they work as expected, so I'm guessing this commit is responsible since that's the only relevant change to the macOS windowing code between 2.23.2 and 2.24.0.

Anyway, it's not a serious problem for my usage (only caught it because of the pysdl2 unit test suite), but figured it's the type of thing I should report upstream!

a-hurst avatar Sep 03 '22 02:09 a-hurst

I'm away from my mac for the weekend, but I'll check this early next week!

icculus avatar Sep 03 '22 04:09 icculus

I'll check this early next week!

"Next week" is such a relative term. 😜

This is fixed in revision control now, though; sorry for the delay!

icculus avatar Sep 27 '22 18:09 icculus

@icculus A flexible definition of "next week" is an inescapable part of software maintenance 🙂 Thanks for the fix!

a-hurst avatar Sep 27 '22 19:09 a-hurst