SDL icon indicating copy to clipboard operation
SDL copied to clipboard

The start of checking for reverse scroll direction (mouse and touchpad seperately)

Open Axilot opened this issue 2 years ago • 9 comments

I have implemented the ability for us to detect whether a mousewheel event is caused by an actual mouse or mousepad. With this feature we can then further work on supporting "natural scrolling", "reverse scroll direction" or however you want to call it.

Fixes #5066

Axilot avatar Jul 27 '22 11:07 Axilot

This is a good start, thanks! I'm going to hold off merging this until 2.24.0 ships.

slouken avatar Jul 27 '22 12:07 slouken

Can you mark this as a draft pull request so we don’t accidentally merge it before you’re ready?

slouken avatar Jul 27 '22 13:07 slouken

Can you mark this as a draft pull request so we don’t accidentally merge it before you’re ready?

On the right of the initial message, there is a link to convert to a draft. (below the list of reviewers) Looks like maintainers can do this as well.

madebr avatar Jul 27 '22 13:07 madebr

This might be a weird question but is there some kernel protection mechanism implemented in the OS, that prevents you from making multiple open syscalls?

Axilot avatar Jul 29 '22 13:07 Axilot

Nevermind. I had too many file descriptors open. After I've increased the limit, everything started working fine again.

Axilot avatar Jul 29 '22 13:07 Axilot

We finally have it working on XFCE!

Axilot avatar Jul 29 '22 21:07 Axilot

Could we re-run the checks, please?

Axilot avatar Jul 30 '22 08:07 Axilot

Now it should build on macOS too. Could we re-run again, please?

Axilot avatar Aug 01 '22 16:08 Axilot

Could we re-run the tests again, please? Now that the main branch is fine, the build should finally succeed, right? And a question: Why can't I myself restart these tests?

Axilot avatar Aug 01 '22 18:08 Axilot

Oh gosh, I don't think we want to add an XML library to SDL for this. If it's going to come to that, and custom code for each window manager, we'd rather go to the xdg committee and ask for some sort of standard where window managers set a property we can query and just leave it unsupported on other window managers.

I'm going to close this PR for now, but we'll leave #5066 open so we can revisit this later.

icculus avatar Nov 23 '22 18:11 icculus