SDL icon indicating copy to clipboard operation
SDL copied to clipboard

Updates and fixes to build_configs

Open Lzard opened this issue 1 year ago • 1 comments

Adds missing macro definitions to SDL_build_config.h.cmake, removes unused ones, changes unneeded @VAR@ replacements to 1s, and fixes a few little things.

Those are issues I came across while working with SDL_build_config.h.cmake for a personal project that uses CMake configuration headers, but not CMake itself.

Lzard avatar Nov 02 '24 20:11 Lzard

@madebr, can you take a look at this? It mostly looks good to me, I just want a second pair of eyes on this.

slouken avatar Dec 04 '24 19:12 slouken

@madebr, ping?

slouken avatar Dec 24 '24 01:12 slouken

Rebased and fixed the issues:

  • SDL_REVISION will indeed always be defined, so I dropped the related commit.
  • HAVE_LIBUNWIND_H removed.
  • calloc, free and realloc removed from symbols_to_check and _copysign and _fseeki64 added to it on Windows.

Lzard avatar Dec 24 '24 12:12 Lzard

Looks good, thanks!

slouken avatar Dec 24 '24 15:12 slouken