SDL icon indicating copy to clipboard operation
SDL copied to clipboard

testautomation --filter render_testBlendModes fails with vulkan renderer

Open madebr opened this issue 1 year ago • 1 comments

Command:

test/testautomation  --filter render_testBlendModes --renderer vulkan

Grepping Failed, these assertions fail:

ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB color modulation operation results, expected 0,64,226,255, got 115,122,138,255': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB color modulation operation results, expected 0,64,226,255, got 115,122,138,141': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB alpha modulation operation results, expected 10,128,240,255, got 116,128,139,255': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB alpha modulation operation results, expected 10,128,240,255, got 116,128,139,141': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render point SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,100': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render line SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,100': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render rect SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,100': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,26': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,26': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render ARGB SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,100': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_BLEND operation results, expected 10,128,240,255, got 116,128,139,255': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_BLEND operation results, expected 10,128,240,255, got 116,128,139,141': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_BLEND_PREMULTIPLIED operation results, expected 10,128,240,255, got 125,243,255,255': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_BLEND_PREMULTIPLIED operation results, expected 10,128,240,255, got 125,243,255,141': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_ADD operation results, expected 138,255,255,255, got 129,141,152,255': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_ADD operation results, expected 138,255,255,128, got 129,141,152,128': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_MUL operation results, expected 5,64,120,255, got 120,179,235,255': Failed
ERROR: 07/28/24 03:58:34: Assert 'Checking render XRGB SDL_BLENDMODE_MUL operation results, expected 5,64,120,128, got 120,179,235,128': Failed

madebr avatar Jul 28 '24 02:07 madebr

I can repro with Vulkan as well as D3D. I'll have to check whether the software renderer or the 3D renderer is correct.

slouken avatar Jul 28 '24 02:07 slouken

These 4 also fail on Metal:

macbuildbot:buildbot icculus$ test/testautomation  --filter render_testBlendModes 2>&1 |grep Failed
2025-01-13 12:17:36.057 testautomation[43815:5231960] ERROR: 01/13/25 12:17:36: Assert 'Checking render point SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,100': Failed
2025-01-13 12:17:36.058 testautomation[43815:5231960] ERROR: 01/13/25 12:17:36: Assert 'Checking render line SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,100': Failed
2025-01-13 12:17:36.059 testautomation[43815:5231960] ERROR: 01/13/25 12:17:36: Assert 'Checking render rect SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,100': Failed
2025-01-13 12:17:36.061 testautomation[43815:5231960] ERROR: 01/13/25 12:17:36: Assert 'Checking render ARGB SDL_BLENDMODE_NONE operation results, expected 10,128,240,255, got 10,128,240,100': Failed

OpenGL and the software renderer pass everything.

The "gpu" backend passes everything, too, on both Metal and Vulkan.

icculus avatar Jan 13 '25 17:01 icculus

9b454a762c188abb4a191ded6f95e6afc7411d74 fixes metal and the D3D renderers, and a036aeda3b27ce7e115ebf25e717adf0bdabe91e does the final step to fix this for Vulkan.

slouken avatar Jan 20 '25 21:01 slouken