Approval email with the wrong name 🐛

[chartgerink]

URL of the Page

No response

What happened?

I received an email about an author approving a module, but it was in my name (where I'd previously approved that module).

It seems like something is going wrong in terms of the email sending. We should double check and test multi-author situations and the email sending a bit more.

Steps to reproduce

No response

What browser(s) did you use?

No response

Anything else?

[nsunami]

I tested this as follows:

1. Click "Approve to publish"

2. Get an email

It looks like the names are fine, but the "reply-to" field is set to Chris Hartgerink [email protected].

[chartgerink]

I got a report from a person using the platform that this error occurred for them. It might look like everything is fine in the test environment because of using similar names for your different test accounts (I had this issue!).

The reply-to field is correct - it is set that way intentionally right now 😊

[nsunami]

I tried sending an invitation email to my second account again today, but I did not receive an email. (quirrel-related?) I also saw that my quirrel dashboard was not showing any tasks. It's possible that my environment is not good.

[chartgerink]

Another report of this - I just got an email and I def didn't approve one.

It's not selecting the right name so should be a quick fix. Bumping this for priority too.

[nsunami]

I'm trying to reproduce the issue here:

1. Create a draft in Account 1
2. Invite Account 2 (email verified & consented to receiving emails)
3. The invitation email looks normal ✅
4. In Account 2, approve the draft
5. I was unable to receive the approval email to my Account 2 on my test environment ❓

Looking more now...

(node:18489) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 pmessage listeners added to [RedisMock]. Use emitter.setMaxListeners() to increase limit
(Use `node --trace-warnings ...` to show where the warning was created)
``

[nsunami]

I think I finally have a replicable step for this.

1. Prepare two accounts (with email settings turned on)
2. Have Account 1 create a draft and add Account 2 as a co-author.
3. Account 2 approves the co-authorship & approves the draft
4. In Account 1, change the main file, and re-approve the draft
5. Email will be sent to Account 1, saying that Account 1 approved the draft, as expected.
6. However, an email will be sent out to Account 2, that Account 2 approved the module, while in reality, Account 1 was the one that approved the module.