libretro-common icon indicating copy to clipboard operation
libretro-common copied to clipboard

VFS Broken since CDRom change?

Open RobLoach opened this issue 5 years ago • 4 comments

vendor/libretro-common/vfs/vfs_implementation_cdrom.c: In function ‘retro_vfs_file_seek_cdrom’: vendor/libretro-common/vfs/vfs_implementation_cdrom.c:49:19: error: ‘libretro_vfs_implementation_file {aka struct libretro_vfs_implementation_file}’ has no member named ‘cdrom’ stream->cdrom.byte_pos = offset; ^~ compilation terminated due to -Wfatal-errors. Makefile:25: recipe for target 'vendor/libretro-common/vfs/vfs_implementation_cdrom.o' failed make: *** [vendor/libretro-common/vfs/vfs_implementation_cdrom.o] Error 1

https://github.com/libretro/libretro-common/blob/master/vfs/vfs_implementation_cdrom.c#L49

RobLoach avatar Jul 13 '19 14:07 RobLoach

I confirm this at least breaks 4DO and other cores on Haiku https://github.com/libretro/4do-libretro/issues/132

kwyxz avatar Oct 26 '19 07:10 kwyxz

Sorry for the bump, but got other cores that use VFS for CDROMs? Wouldn't mind this for testing.

mudlord avatar Jan 07 '23 22:01 mudlord

@mudlord found another one, Haiku build of neocd_libretro is broken unless HAVE_CDROM is set to 0 when running make:

deps/libretro-common/cdrom/cdrom.c: In function 'cdrom_send_command':
deps/libretro-common/cdrom/cdrom.c:523:7: error: 'else' without a previous 'if'
  523 |       else
      |       ^~~~

kwyxz avatar Feb 16 '23 02:02 kwyxz

Thanks very much, was pondering adding my own CD reading stuff to WTFweg, so neocd_libretro would be nice to test too.

mudlord avatar Feb 20 '23 08:02 mudlord