dosbox-libretro
dosbox-libretro copied to clipboard
libretro
Add back install and uninstall rules
The GNOME Games Flatpak installation relies on these rules to be there so I can't approve that MR more.
Ah, it wasn't intentional, practically rewrote the core based on my new dosbox-svn core, sorry.
On Thu, Aug 9, 2018 at 11:34 AM Adrien Plazas [email protected] wrote:
We rely on these rules for GNOME Games' Flatpak installation.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/libretro/dosbox-libretro/pull/97#issuecomment-411819569, or mute the thread https://github.com/notifications/unsubscribe-auth/ABpC0Ekv4MXqYWZc6M687gGCcVE0DNowks5uPGSlgaJpZM4V2BaR .
You probably should add them too fr500/dosbox_svn instead, it's a faster core (and I can merge it there)
fr500/dosbox_svn seems to introduce SDL dependency, which isn't ideal for us. Any reason not to merge this, considering other PRs are being merged?
I have no idea I have no control over libretro repos. It introduces SVN because dosbox has always used SVN for many things (timers, threads, CD-ROM)
Ah, and you're the only person besides Adrien who received a notification. Sorry :(
As for dependency, aren't libretro cores meant to be self-contained? I.e. I don't know any other core that has external dependencies (not saying there aren't any, just I don't know any :D)
@twinaphex since you're the person who merged the last MR here, mind taking a look at this one?
@Exalm
External libraries can be compiled in statically, lots of cores do this AFAIK.
@fr500
I think only SDL_sound (mp3/wav/aiff track support) is used for CDROM, right?
BTW there's a very good SDL2 port that I've been using for a long time here: https://github.com/duganchen
Sorry for the off topic, just thought it may be interesting.
