beetle-psx-libretro icon indicating copy to clipboard operation
beetle-psx-libretro copied to clipboard

Published 20 hours ago • verified publisher icon libretro

Graphic issue after latest changes

Open Kupo91 opened this issue 4 years ago • 10 comments

Edit: I tested the old core versions from the buildbot. The last working core is the one from 27th september. The issue occured for the first time with the core from 28th september.

I just updated my core a few days ago. After updating the character sprites in certain positions have these extra pixel strips which don't belong there. I'm not good at explaining so here are some screenshots:

Grandia D SLES-02399 -201014-104623 Grandia D SLES-02399 -201014-104809 Grandia D SLES-02399 -201014-105123 Grandia D SLES-02399 -201014-105159 Grandia D SLES-02399 -201014-105213

The Game is Grandia and I think you can see these pixel strips only in battles and if internal resolution is atleast x2.

I restored an old core from 2nd of july and this core does not have this issue! So it seems like some of the latest changes causes this problem.

  • Frontend: Retroarch Oct 12 2019
  • OS: Linux (v5.3)
  • GPU: Intel Iris Plus Graphics 655, video driver is vulkan

Kupo91 avatar Oct 14 '20 09:10 Kupo91

I can reproduce on Windows 10 also, bisect done, first bad commit is 6f8751a.

bslenul avatar Oct 14 '20 11:10 bslenul

I see a new core option "Texture UV Offset" with the description "Sample textures for 3D polygons at an offset for higher than 1x internal resolution. Reduce texture seams but may cause unintended graphical glitches." in that commit, it's enabled by default so did you try disabling it ? (imho that's probably something that should be disabled by default if it's causing gfx issues)

barbudreadmon avatar Oct 14 '20 13:10 barbudreadmon

I just tried turning it OFF (then close content just to be sure) and the same thing still happens for me.

bslenul avatar Oct 14 '20 14:10 bslenul

Hi @xzn , can you check out this regression? Thanks in advance.

inactive123 avatar Oct 14 '20 15:10 inactive123

Sorry for the late reply just had a bit of free time a few hours ago.. I removed the offending code that's causing the problem in the new pr. The code in question was for Valkyrie Profile and now that I've looked a bit further it was technically an enhancement not a bug-fix so since it's causing glitches in other games it should just be removed.

Sorry for the trouble.

xzn avatar Oct 15 '20 01:10 xzn

Can confirm (if needed :p) that the bug is gone now, thank you! ❤️

Sorry for the trouble.

Heh, switching to a few weeks old core wasn't the end of the world :p

bslenul avatar Oct 15 '20 09:10 bslenul

Ye no issues in todays core version. Thank your for this fast fix

Kupo91 avatar Oct 15 '20 18:10 Kupo91

@xzn Hey, sorry to say this but there's another issue due to that same 6f8751a commit, but this time it only seems to affect Vulkan at 1x (see Crash's back on the last 2 screenshots):

image image image

It doesn't seem to affect every game however. I'll open a new issue for this if you prefer.

bslenul avatar Oct 15 '20 22:10 bslenul

I forgot to add unscaled variant to the flat primitive vertex shader...

Don't know why I didn't catch this though? I thought I tested this in Crash Bandicoot in 1x as well, must've missed it..

xzn avatar Oct 16 '20 04:10 xzn

Thank you for the fix! 👍

bslenul avatar Oct 16 '20 09:10 bslenul