RetroArch
RetroArch copied to clipboard
libretro
[Feature Request] `Load State` improvements
Rationale
Save States are not always backward compatible after core updates.[1] I have personally experienced loss of significant gameplay time due to Save States becoming unusable after updating a core. Including this information in the description would help users who rely on Save States understand the importance of locking their core version, especially if the core is known to have Save State incompatibilities between versions.
Benefit
This change would make the option more informative and help prevent accidental data loss for users who are unaware of Save State compatibility issues.
This is a very easy change to apply and will make a huge difference for users.
Feature reques
If there is no ".state" file
Option 1) Hide "Load State"
To enhance usability when there is no corresponding ".state" file for the game, hide the "Load State" entry:[1]
Option 2) Display "No such file."
Change:
Failed to load state from "[anygame].state."
to
Failed to load state from "[anygame].state: No such file.
If there is a ".state" file
-
Load State -> Select any game
-
-
Change to
Failed to load state from "[anygame].state." Note: may not work if state was saved with another version of the core.
I suggest the added text "Note: may not..." since it is added in PR https://github.com/libretro/RetroArch/pull/17901
zoltanvb commented on the "Load State-specific improvements" section in the top post:
Disabling load state if there is no state to load: may be viable (in a different PR), needs a bit of thought and experimenting to see how disturbing it is when the state index is moved to an invalid slot on game load, but some other state would be available. Menu items cannot be greyed out currently, only completely hidden.
Extending the load state failure message: not sure yet, will consider together with the load state disabling.
@zoltanvb Just for your information: I’ve merged this issue (specifically the unresolved section from issue #17836) since libretroadmin closed it. If you’d like, you can update "partially fixes" to "Fixes" in PR #17901.
I also just submitted a related feature request:
- https://github.com/libretro/RetroArch/issues/17943