libretro
Add option to disable analog stick menu navigation
Description
Two new settings added to Settings / Input / Menu Control:
- disable left analog stick in menu navigation
- disable right analog stick in menu navigation
Since the logic for menu control by analog stick is already a distinct flow in input driver.c, no change was necessary to analog-to-digital settings or other mappings. Defaults are false (i.e. all sticks control menu).
Related Issues
Closes #16274 May provide a workaround for #16644
Reviewers
@sonninnos
I was rather looking forward to complete customization and the removal of "disable" options instead of adding more, but that can be done later I guess.
I was considering extending it, and I can still do it, if you consider it better. My line of thinking was:
- currently, only right analog stick removal was requested
- allowing the D-pad to be excluded from menu navigation can lock the user out immediately So this is why 2 simple options were added. But I can swing either way, remove left analog stick exclusion (which was not asked so far) and leaving only 1 simple toggle for right analog, or do a combined option, with or without D-pad removal.
D-pad never needs to be customized or removed. I was referring to all other buttons, excluding ok+cancel of course.
Would it not be safe to just disable the right analog stick altogether and fore go the options? I'd consider myself a power user and until seeing this, I had no idea that the right analog stick even did anything at all.
Ah, total customization, I get the point. That is indeed a bit more than what I was looking for, so I will not include it to this PR.
Right analog stick has been in the code since #14579 and it mentions a request, so I would also not remove it unconditionally.
From my side, PR is finalized.
@zoltanvb I think it will be a good idea to insert these options, meanwhile we are waiting for a total customisation. For people who are using R3 as Hotkey enable it would solve an annoying situation. Thanks.
@sonninnos @zoltanvb sorry guys but I don’t understand if these options should be already implemented.
I downloaded the latest nightly builds for Android and Mac and I can’t find the preferences in the menu:
@sonninnos sorry for the stupid question, but what’s the reason because it has not been merged?
@zoltanvb could you merge this one please? It would be really nice to have these options. Thanks!