RetroArch icon indicating copy to clipboard operation
RetroArch copied to clipboard

`Load Configuration` followed by `Quit` does not save retroarch.cfg

Open davidhedlund opened this issue 1 year ago • 8 comments

Describe the issue

On many Android devices, you can't access certain folders (such as /storage/emulated/0/Android/data/) without special permissions. This makes it tricky to copy a RetroArch configuration file (retroarch.cfg) to its usual location (/storage/emulated/0/Android/data/com.retroarch/files/retroarch.cfg). The result? Settings have to be done manually, taking up precious gaming time.

Expected behavior

The settings should be saved to retroarch.cfg.

Actual behavior

The settings have not been saved to retroarch.cfg.

Steps to reproduce the bug

  • Main Menu -> Configuration File -> Load Configuration, select your retroarch.cfg file
  • Main Menu -> Quit -- It does not save the settings to retroarch.cfg.

Version/Commit

You can find this information under Information/System Information

  • RetroArch: 1.17.0 apk from retroarch.com

Environment information

  • OS: Android

davidhedlund avatar May 02 '24 13:05 davidhedlund

WAT? Yes it does... Mind providing the verbose logs?

RobLoach avatar May 17 '24 16:05 RobLoach

Duplicate of https://github.com/libretro/RetroArch/issues/13548

sonninnos avatar May 17 '24 16:05 sonninnos

maybe the loaded config has "save on exit" = false? and even when set to true, it should probably save to the loaded config file, not the the default config file (retroarch.cfg).

ToKe79 avatar May 20 '24 10:05 ToKe79

maybe the loaded config has "save on exit" = false?

No, config_save_on_exit = "false" is not added to my config file.

and even when set to true, it should probably save to the loaded config file, not the the default config file (retroarch.cfg).

It does that currently. But that is an issue for me, because the config file that I load only contains a few config lines, and RA adds all default settings to it. I have to circumvent this.[1]

Also, the next time you start RA, and close it, it will save it to the default /storage/emulated/0/Android/data/com.retroarch/files/retroarch.cfg

1: I circumvent this by copying my config file to /storage/emulated/0/Android/data/com.retroarch/files/retroarch.cfg

davidhedlund avatar May 20 '24 18:05 davidhedlund

WAT? Yes it does... Mind providing the verbose logs?

Sorry, but the stack trace is too long to make it convenient for me. However, you can reproduce it yourself. Here are the most relevant config lines that I'm using:

fps_show = "true"
screen_orientation = "1"

davidhedlund avatar May 20 '24 18:05 davidhedlund

@davidhedlund in that case configure retroarch as you want, except those two options (have them as you want them as "default"). then save the configuration. then modify those two settings and save it as new configuration - it will have all your custom configuration + those two config options different as default. or if you want to use these settings with a specific game/core/roms folder, after loading, change these options and then save as game/core/content directory override in quick menu and they will be applied when loading that specific game / using that specific core / loading game from that specific folder.

ToKe79 avatar May 20 '24 21:05 ToKe79

@davidhedlund in that case configure retroarch as you want, except those two options (have them as you want them as "default"). then save the configuration. then modify those two settings and save it as new configuration - it will have all your custom configuration + those two config options different as default. or if you want to use these settings with a specific game/core/roms folder, after loading, change these options and then save as game/core/content directory override in quick menu and they will be applied when loading that specific game / using that specific core / loading game from that specific folder.

I'm familiar with the existing workarounds, I just reported this issue in the hope that I can be solved so to prevent future users from needing them.

davidhedlund avatar May 21 '24 04:05 davidhedlund

WAT? Yes it does... Mind providing the verbose logs?

ToKe79 just contributed to a piece of code that you might want to take a look at:

  • https://github.com/libretro/RetroArch/issues/13548#issuecomment-2121744690

davidhedlund avatar May 21 '24 05:05 davidhedlund