RetroArch 1.17.0 for Android: Remap regression bugs

[davidhedlund]

None of the below issues occur in RetroArch for Android version 1.16.0, only in version 1.17.0.

Gamepad controller activation of "Set All Controls" does not request R2 to be set.

• Go to: Settings -> Input -> RetroPad Binds -> Port 1 Controls
• Use a gamepad controller and press the face button that will activate "Set All Controls"
• All buttons are requested to be remapped, except R2.

Evaluated in Android 13 with a Sony DualSense controller.

Screen touch activation issues

Description

Affects entries in:

• Settings -> Input -> RetroPad Binds -> Port * Controls
• Settings -> Input -> Hotkeys

If you touch a menu entry to activate button remapping. This does not happend if you press the controller button to activate it.

• 1.16.0: 3 seconds
• 1.17.0: 0.2~ second -- you will barely see it, so there's a risk that you don't remap it

There's a risk that people will upload incomplete autoconfig files to https://github.com/libretro/retroarch-joypad-autoconfig

"Set All Controls"

"Set All Controls" -> "D-Pad Up" (the first button that pop-ups):

• 1.16.0: 3 seconds

1.17.0:

• D-PAD up appears for 0.2~ second (it's very difficult to detect it)! More importantly, the "Set All Controls" process it not cancelled when the D-pad Up is not pressed.

If you press D-Pad Up during "Set All Controls", then these buttons are not requested automatically:

• "B Button (Down)" is not requested later.

These buttons are sometimes never requested to be remapped (not even for a blink of an eye) regardless if you pressed D-Pad Up earlier or not:

• L3, and R3
• Right thumb stick Up

Version/Commit

You can find this information under Information/System Information

• RetroArch: 1.17.0 via https://buildbot.libretro.com/stable/1.17.0/android/RetroArch.apk

Environment information

• OS: I could reproduce this issue in both Android 10, and Android 13.

[davidhedlund]

@LibretroAdmin This issue should be highly prioritized. Can you please label it?

[LibretroAdmin]

I'll let @sonninnos know about it, since I think he last handled the input remapping code.

[davidhedlund]

I'll let @sonninnos know about it, since I think he last handled the input remapping code.

Thank you very much.

[davidhedlund]

@sonninnos These bugs persist in https://buildbot.libretro.com/stable/1.19.1/android/RetroArch.apk it makes it very inconvenient for people to configure controllers. Have you taken a look at this yet?

[sonninnos]

Works fine here. Bind timeout is respected, and when setting all it proceeds to the next one in proper order without missing any, and if timeout is triggered, it stops the whole process, because forcefully continuing to the end without a way to quit is way more annoying.

Tested on Windows, and zero idea how platform could make any difference with that code.