RetroArch icon indicating copy to clipboard operation
RetroArch copied to clipboard

[Feature request] Quit RetroArch: Display "Saved new config to [config directory]/retroarch.cfg" before the program closes

Open davidhedlund opened this issue 1 year ago • 5 comments

Expected behavior

  • Settings -> Configuration -> Save Configuration on Quit -- should display "Saved new config to [config directory]/retroarch.cfg". The message could be visible for about 2 seconds (because that is how long they are visible when RA is open) before the program quit, in order to inform the user.

Actual behavior

  • Settings -> Configuration -> Save Configuration on Quit -- does not display "Saved new config to [config directory]/retroarch.cfg"

Steps to reproduce the bug

  • Main Menu -> Settings -> Configuration File -> Save Current Configuration -- displays "Saved new config to [config directory]/retroarch.cfg". The message is visible for about 4 seconds.

Screenshot from Android: image

  • Settings -> Configuration -> Save Configuration on Quit -- does not display the above message

Version/Commit

You can find this information under Information/System Information

  • RetroArch: 1.17.0 apk from retroarch.com

Environment information

  • OS: Android

davidhedlund avatar Jan 09 '24 05:01 davidhedlund

Forcing the delaying of the quitting in order to see the message on every single quit is going to be a showstopper though..

sonninnos avatar Jan 09 '24 08:01 sonninnos

Forcing the delaying of the quitting in order to see the message on every single quit is going to be a showstopper though..

I think it's ok if:

  • The message is only displayed if the settings are saved.
  • The message is displayed for 1 second (also an additional setting, say "Show quit message for: x seconds" could be implemented).

What do you think about it?

davidhedlund avatar Jan 09 '24 10:01 davidhedlund

  • https://github.com/libretro/RetroArch/issues/16000
  • https://github.com/libretro/RetroArch/issues/16097

davidhedlund avatar Jan 09 '24 10:01 davidhedlund

As far as I can tell, there is a false statement here - changing the config directory doesn't actually change where the config file is saved except for this current run of RetroArch. When you reload the app, it automatically opens the on in /data/ even if you have set the config data elsewhere. This is problematic because that file is inaccessible. (There should be an way to actually change that permanently, or at least import an external config file into that inaccessible one from the GUI)

DavidRGriswold avatar Apr 19 '24 09:04 DavidRGriswold

As far as I can tell, there is a false statement here - changing the config directory doesn't actually change where the config file is saved except for this current run of RetroArch. When you reload the app, it automatically opens the on in /data/ even if you have set the config data elsewhere. This is problematic because that file is inaccessible. (There should be an way to actually change that permanently, or at least import an external config file into that inaccessible one from the GUI)

Thank you. I updated the top post, and submitted:

  • https://github.com/libretro/RetroArch/issues/16491
  • https://github.com/libretro/RetroArch/issues/16490

davidhedlund avatar May 02 '24 13:05 davidhedlund