portable icon indicating copy to clipboard operation
portable copied to clipboard

none code guru Patch question for OPENSSL_thread_stop()

Open AliceWonderMiscreations opened this issue 7 years ago • 1 comments

Hi - trying to build OpenDKIM 2.11.0 beta 2 against LibreSSL 2.8.2.

Found in two places I needed this to get to compile -

-#if OPENSSL_VERSION_NUMBER >= 0x10100000
+#if OPENSSL_VERSION_NUMBER >= 0x10100000 && !defined (LIBRESSL_VERSION_NUMBER)

Both of those were to avoid using

OPENSSL_thread_stop();

which appears to be in newer OpenSSL but not LibreSSL

Is there maybe a better way, to feature detect support for OPENSSL_thread_stop() itself rather that based upon version number values and definitions? That would seem to be better since in both cases it seems to be a single feature.

AliceWonderMiscreations avatar Nov 23 '18 11:11 AliceWonderMiscreations

We have no reason to deallocate threads resources directly yet, so it could be implemented as a no-op stub for now.

busterb avatar Nov 25 '18 12:11 busterb