The assets might be built with wrong runtime

Open KristianIvarsson opened this issue 11 months ago • 2 comments

The asset libressl_v4.0.0_windows_x64.zip seems to been built with (Runtime Library) /MD but since it is supposed to be a static library, perhaps /MT should be used (otherwise some symbols won't be present)

Jan 22 '25 13:01 KristianIvarsson

Hi! The Windows release assets are built by GitHub Actions in this workflow: https://github.com/libressl/portable/blob/master/.github/workflows/release.yml#L36

I am not too familiar with the Windows build process, however I will have a closer look soon (or if someone else with more knowledge with this could help, that would be great). - Otherwise, if you know how this could be resolved, a pull request would be very helpful and appreciated.

Thanks.

Jan 22 '25 19:01 joshuasing

I'd love to help out, but time is limited right now

It looks like you should be able to do set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded") somewhere

Note, some CMAKE-versions seems to have a defect with this though

Jan 23 '25 10:01 KristianIvarsson