librespot icon indicating copy to clipboard operation
librespot copied to clipboard

Update `glib` and `gstreamer`

Open yubiuser opened this issue 1 year ago • 1 comments

librespot-playback
/workspaces/librespot/playback/Cargo.toml
dependency       current  upgrade
glib             0.19.9   0.20.2
gstreamer        0.22.7   0.23.1
gstreamer-app    0.22.6   0.23.0
gstreamer-audio  0.22.6   0.23.0

The upstream bug has been fixed. Just need to wait before dependencies pick up the new version and it propagates through the crates.

yubiuser avatar Sep 06 '24 15:09 yubiuser

It will take a few days or weeks (and likely a patch update to the dependencies) before librespot will successful build.

yubiuser avatar Sep 06 '24 16:09 yubiuser

Updating to jack v0.13 would bump the MSRV to 1.80 as it makes use of LazyCell and LazyLock feature which is considered unstable in 1.74. (See https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#lazycell-and-lazylock)

I'm hesitating to upgrade that much...

yubiuser avatar Sep 25 '24 19:09 yubiuser

Looking at the difference between 0.12 and 0.13 I see nothing of particular interest to librespot.

roderickvd avatar Sep 25 '24 19:09 roderickvd

~~Went back to jack 0.12.~~

Edit: Turns out also v0.12 already uses LazyCell and LazyLock

yubiuser avatar Sep 25 '24 19:09 yubiuser

I fored pushed away the jack commits

yubiuser avatar Sep 26 '24 09:09 yubiuser

Thanks. Can you resolve the conflicts? Sorry for merging a later PR first, which caused this probably.

roderickvd avatar Sep 30 '24 19:09 roderickvd