Always Unknown ISP on standard ISP

[GerdRuetten]

Description

I using speedtest as docker compose in the latest version (and testing with dev-branch). I using the servers.json from your side. On all ISP i get "Unknown ISP". Only my own ISP (Deutsche Glasfaser) / Testserver is show me up

Server

Docker compose with:

version: '3.7'
services:
  speedtest:
    container_name: speedtest
    image: ghcr.io/librespeed/speedtest:latest
    restart: always
    environment:
      MODE: dual
      TITLE: "Speedtest - ruetten.ovh"
      TELEMETRY: "true"
      ENABLE_ID_OBFUSCATION: "false"
      REDACT_IP_ADDRESSES: "false"
      PASSWORD: "password"
      EMAIL: "[email protected]"
      DISABLE_IPINFO: "false"
      DISTANCE: "km"
      WEBPORT: 8686
    ports:
      - "8686:8686" # webport mapping (host:container)
    volumes:
      - ./data/database:/database
      - ./data/servers.json:/servers.json

Client

Chrome

Steps to reproduce

You can test it under: https://speedtest.ruetten.ovh

Expected behaviour

Resolve the ISP

Screenshots

My own ISP/Testserver

[sstidl]

I think you need to set your own api key for ispinfo IPINFO_APIKEY=XXXX in the compose file

[Razuuu]

My ISP is "Telefónica Germany Gmbh & Co OHG" and i am using librespeed.org. It says Unknown ISP. https://librespeed.org/results/?id=0cetf22 IPInfo.io says: org:"AS6805 Telefonica Germany GmbH & Co.OHG",

[sstidl]

My ISP is "Telefónica Germany Gmbh & Co OHG" and i am using librespeed.org. It says Unknown ISP. https://librespeed.org/results/?id=0cetf22 IPInfo.io says: org:"AS6805 Telefonica Germany GmbH & Co.OHG",

This means that the provider of the service there has to use a new API key.

[sstidl]

I tested more of the hosts at librespeed.org @adolfintel they all showed unknown IP. So maybe you have to renew the API key used at your side? On my private deployment it works correctly with my own key.

[adolfintel]

@sstidl The problem is ipinfo itself.

They offered a free unlimited API key a few years ago to this project and all was fine until a few months ago when it started being limited like any other key. I tried contacting their support and had no response. I guess they're no longer offering free keys to open source projects?

[sstidl]

@adolfintel
I registered and got my own free plan API key. Maybe you need to register again?

You cannot share the key but use it in your deployment at librespeed.org

[adolfintel]

@sstidl No, the key they gave us was specifically for this kind of use.

The agreement was that the key was available for free for librespeed.org and individual users of the project, while I would direct businesses to buy a key from them.

It was changed once due to abuse a few years ago, but it was still a free and unlimited key for users of LS.

What bothers me is that they didn't even warn me about this change, it just happened from one day to the next, and they didn't even answer my email. I don't have time to get rid of ipinfo from the project right now, but if anyone wants to do it, I highly encourage to replace it with a local database or something.

[sstidl]

I just checked the code. You just have to remove the API key from config and it should work. They have a public API without API key. I alread fixed that a time ago in
https://github.com/librespeed/speedtest/blob/dd1ce2cb8830d94dcaa0b8e70b9406144a0e5f8d/backend/getIP.php#L75

so https://ipinfo.io/8.8.8.8/json is the best you can get without an account. but this should be enough information?

[sstidl]

@adolfintel i close this issue as it is explained how to fix the situation.