speedtest icon indicating copy to clipboard operation
speedtest copied to clipboard

Update the unit symbols

Open getsnoopy opened this issue 5 years ago • 8 comments

The ad-hoc abbreviation "Mbps" for "megabits per second" was used originally to refer to the unit since an official symbol did not exist at the time. An official symbol now exists and the abbreviation has been deprecated, so this commit updates these to the official symbol.

getsnoopy avatar May 05 '20 22:05 getsnoopy

Nice, I didn't know there was an official symbol. Your PR makes a bit of a mess in the markdown files, can you fix that?

adolfintel avatar May 06 '20 05:05 adolfintel

Are you referring to the trailing whitespaces being removed? I think that's automatic, which is good since they shouldn't exist anyway.

getsnoopy avatar May 06 '20 19:05 getsnoopy

Yes, the spaces have nothing to do with your correction. You should make a second commit for that

adolfintel avatar May 06 '20 19:05 adolfintel

Done.

getsnoopy avatar May 06 '20 21:05 getsnoopy

Does the PR look good to you? Let's merge it in if so.

getsnoopy avatar May 20 '20 17:05 getsnoopy

Yes, it's good. I will merge it when I get around to do the same thing for the Android version

adolfintel avatar May 20 '20 17:05 adolfintel

Whenever you merge it, you may consider also adding and updating this commit: https://github.com/denilsonsa/speedtest/commit/a3f127e56e9f19b7fcd411122437e1cd857dedc4

denilsonsa avatar Feb 27 '21 22:02 denilsonsa

@adolfintel Fixed the merge conflicts. @denilsonsa It looks like your commit is not merged in yet, so it would be better for you to fix the Mbps to Mbit/s in your commit and then do a separate pull request.

getsnoopy avatar Feb 27 '21 23:02 getsnoopy

I will look at this. Seems to be a simple find & replace in the repo.

sstidl avatar Nov 04 '23 14:11 sstidl

@sstidl Feel free to look and incorporate at any pending commits from my branch. It's been 2½ years since I wrote them, and I haven't used librespeed myself in quite some time.

denilsonsa avatar Nov 04 '23 21:11 denilsonsa

solved by #581

sstidl avatar Nov 05 '23 00:11 sstidl