librenms icon indicating copy to clipboard operation
librenms copied to clipboard

Adding support for SiteBoss360 appliance

Open Pyrrotech opened this issue 2 years ago • 6 comments

Includes YAML files for OS as well as MIBS.

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • [ ] Have you followed our code guidelines?
  • [ ] If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • [ ] If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926 After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Pyrrotech avatar Aug 14 '23 20:08 Pyrrotech

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 14 '23 20:08 CLAassistant

Please add test data so we can ensure your change is not broken in the future. Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

github-actions[bot] avatar Aug 14 '23 21:08 github-actions[bot]

This seems to be a duplicate of other SiteBoss operating systems (which may already be duplciates).

What makes this a distinct OS a part from the others?

murrant avatar Aug 21 '23 23:08 murrant

This still needs test data before it can be merged, thanks.

murrant avatar Nov 02 '23 05:11 murrant

Still working on this. Had to put it down to build the new environment for our LibreNMS.

On Thu, Nov 2, 2023 at 12:50 AM Tony Murray @.***> wrote:

This still needs test data before it can be merged.

— Reply to this email directly, view it on GitHub https://github.com/librenms/librenms/pull/15224#issuecomment-1790110920, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADNMWGIR4HUM5ISQBADJERTYCMYEHAVCNFSM6AAAAAA3QFI54WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQGEYTAOJSGA . You are receiving this because you authored the thread.Message ID: @.***>

Pyrrotech avatar Nov 02 '23 14:11 Pyrrotech

Siteboss360 test data.txt

Here is the test data requested. If anything else is needed or missing let me or Pyrrotech know.

Phoenhax avatar Jan 16 '24 18:01 Phoenhax