librenms icon indicating copy to clipboard operation
librenms copied to clipboard
verified publisher icon librenms

Run CI on ubuntu 22.04

Open Jellyfrog opened this issue 3 years ago • 4 comments

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • [ ] Have you followed our code guidelines?
  • [ ] If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • [ ] If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926 After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Jellyfrog avatar Sep 22 '22 10:09 Jellyfrog

This fails due to ubuntu 20.04 got a newer net-snmp that handles weird test data different

Jellyfrog avatar Sep 22 '22 23:09 Jellyfrog

@Jellyfrog at least it would be consistent with most of our dev machines then.

Also, it is not the net-snmp version that affects this, it is the mibs I think.

murrant avatar Sep 26 '22 03:09 murrant

I updated all test data. This had the consequence of adding many modules to tested data (where data existed in the snmprec already).

Should I leave it?

murrant avatar Oct 03 '22 18:10 murrant

It's better we collect changes here than In some device pr we're a bit unsure about.

Jellyfrog avatar Oct 03 '22 19:10 Jellyfrog