docker icon indicating copy to clipboard operation
docker copied to clipboard

Update init checks to be less restrictive

Open duhow opened this issue 2 years ago • 4 comments

As of https://github.com/librenms/docker/pull/283 restrictive check, Docker images after 22.6.0 are not working properly for us.

We are running LibreNMS in Kubernetes, where we have the config.php mounted as ConfigMap (read-only for the file system), and also Redis has disabled FLUSHDB as a safety measure.

Changes applied in here:

  • Ignore errors if cannot clean config.d folder initially.
  • Create new config.d files only if folder is writable.
  • Update chown folders only if are writtable.
  • Ignore if cache:clear fails. (Redis)

duhow avatar Apr 20 '23 13:04 duhow

Question, how do you clear possibly incompatible cached data from redis?

murrant avatar Apr 25 '23 16:04 murrant

I haven't had the "need", but from the current test 22.6 to 23.4 I didn't find any "incompatible issues". @murrant Would it help to show a warning message but continue running the software?

duhow avatar Apr 28 '23 18:04 duhow

@crazy-max can you review changes again and validate?

duhow avatar Oct 17 '23 16:10 duhow