lime-packages
lime-packages copied to clipboard
libremesh
lime-apply: remove it or update it
If watchping isn't installed the following error appears:
root@meshrc-73724b:~# lime-apply
Apply hostname
Reload network config
Reload routing protocols
Failed to parse json data: unexpected character
/usr/bin/lime-apply: line 34: /etc/init.d/watchping: not found
/usr/bin/lime-apply: line 34: /etc/init.d/watchping: not found```
@p4u @axn
Is this workaround still required or can we completely remove it? https://github.com/libremesh/lime-packages/blob/master/packages/lime-system/files/usr/bin/lime-apply#L15
On bmx7 it seems to change and distribute the hostname even without a restarting/reloading bmx7 nor running lime-config
On bmx7 it seems to change and distribute the hostname even without a restarting/reloading bmx7 nor running lime-config
Yes, because procd is handling the reloads...
To my understanding lime-apply is a work-around from pre-procd times. Nowadays services can define reload-triggers and get signalled on configuration changes automatically. Imho lime-apply can be dropped as a whole, I never used it and I'm not aware of any use-cases where a work-around like that would be required. Anyone else?
@dangowrt so Alfred lacks procd support but that should be easy to fix.
Lime apply runs a network reload, so that may be the only thing to run manually, as bmx + Alfred + watching could be reloaded via procd
I never used lime-apply... Can we confirm that all its features are now achieved in another way or completely unneeded?
- [ ] Apply hostname (wut is dis?)
- [x] Reload ALFRED
- [x] BMX6 stuff - Workaround until "bmx6 configReload" updates hostname
- [x] BMX7 stuff
Why would u remove it? As there is a lime-config I think it makes sense to have a lime-apply. I'm using it (via terminal) and webui uses it too.
In addition there are some extra tasks which are not covered by a reload_config or network reliad commans (such as the hostname).
El 14 de gener de 2019 16:08:47 CET, Paul Spooren [email protected] ha escrit:
@p4u @dangowrt you know of a better way to "apply" the hostname?
-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/libremesh/lime-packages/issues/352#issuecomment-454037184
-- Enviat des del meu dispositiu Android amb el K-9 Mail. Disculpeu la brevetat.
Update (reading comments above, seems that alfred and bmx* stuff is not needed anymore, we can delete that. And we should check if stuff is missing) or drop (just rebooting for applying the new configuration)?
I would not label this issue nor easy nor good first issue until we have consensus about what has to be done. What we know is that lime-apply is not 100% reliable because some things need a reboot (like changing the country code).
so let's reboot things to be sure. Remove the tool and adopt the documentation to tell users to reboot after configuration
We shouldn't reboot unless is extremely necesary, the neighbours rely on the infrastructure and we shouldn't asume reboot is harmless in a working network. We can flag which configs need reboot, and suggest it. For now, those that we have detected are:
- country code
- batman-adv vlan change
what else?
