lime-app icon indicating copy to clipboard operation
lime-app copied to clipboard

Integrate FeaturePeek to be able to review storybook changes easier

Open nicopace opened this issue 5 years ago • 5 comments

If we integrate featurepeek we will be able to see how each PR looks like from the github interface without having to download and build the code, streamlining the review process.

nicopace avatar May 29 '20 14:05 nicopace

Here you can see a quick recap of what it enables: https://dashboard.featurepeek.com/peek/237hv52#/0

nicopace avatar May 29 '20 14:05 nicopace

In lime-packages a similar thing is being done using Travis:

https://github.com/libremesh/lime-packages/blob/3e11bd142d9b7cbb58bd5bea6d0bac906484dcca/.travis.yml#L63-L65

in which each PR gets compiled and published on a server (which in the lime-packages case is https://snapshots.libremesh.org/branches which is not working).

ilario avatar Jun 05 '20 09:06 ilario

@nicopace we tried it, but featurepeek requests permission over private repositories. Wich is too much for @spiccinini and me: Imagen Pegada el 2020-8-5 16-56

We are exploring own hosted solutions :)

germanferrero avatar Aug 05 '20 21:08 germanferrero

It looks like private repositories are optional... it is in yellow... isn't there any chance to disable that? (clicking on the yellow thingy)

nicopace avatar Aug 05 '20 21:08 nicopace

Nope...

On Wed, Aug 5, 2020 at 6:34 PM Nicolás Pace [email protected] wrote:

It looks like private repositories are optional... it is in yellow... isn't there any chance to disable that? (clicking on the yellow thingy)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libremesh/lime-app/issues/257#issuecomment-669523904, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD2I2MEVCJHZRT7DXHVPXLR7HF4ZANCNFSM4NODQF7A .

spiccinini avatar Aug 05 '20 21:08 spiccinini