browser_extension icon indicating copy to clipboard operation
browser_extension copied to clipboard

youtube pre-loads in new version?

Open rezad1393 opened this issue 2 years ago • 11 comments

I noticed recently that youtube iframes that get replaced with invidious ones , some times just play video automatically.

I checked and I noticed that it seemed that invidious iframes don't use the setting from addon and preload video. which is a very bad behavior specially with firefox not really having a limit on video preload length (it says the limit is 60 second but most times doesn't respect that even with new empty firefox profiles).

before version 2 this didn't happen. is there anyway for fix this?

rezad1393 avatar Jun 07 '22 15:06 rezad1393

Is it the same as this issue https://github.com/libredirect/libredirect/issues/293#issuecomment-1140508858? Well this issue got fixed and I'll release a new version v2.1 in those days.

ManeraKai avatar Jun 08 '22 01:06 ManeraKai

no. it redirects the embedded ones. but before it used to use my setting as the non-embedded ones so the video would be hls and not a mp4 file, so it would not preload. but now the embedded ones are the 720p mp4 and preload.

firefox doesn't has a limit on preload. it say it does but it works so few times that it is non-existent basically. so any embedded youtube video would be preloaded through invidious and use bandwidth.

rezad1393 avatar Jun 08 '22 01:06 rezad1393

I see, I think I was able to fix this that settings don't apply to iframes from this answer: https://stackoverflow.com/questions/51151183/cookie-not-being-set-in-iframe/63660909#63660909

btw I'm interested how do you change it to HLS? Do you just change the quality setting do DASH

ManeraKai avatar Jun 08 '22 01:06 ManeraKai

Here's a zip file of v2.1 is you wanna test it out, note you should have either Firefox ESR, Developer Edition, Nightly to be able to install unverified extensions: https://github.com/libredirect/libredirect#install-in-firefox-esr-developer-edition-nightly

libredirect-2.1.0.zip

ManeraKai avatar Jun 08 '22 01:06 ManeraKai

sorry I meant dash.

rezad1393 avatar Jun 08 '22 13:06 rezad1393

with the new version 2.1 the bug is still there. I open this page https://www.gsmarena.com/asus_zenfone_8-10893.php and at the bottom the video is preloading and sometimes even autoplays

rezad1393 avatar Jun 10 '22 20:06 rezad1393

hopefully it should be working now, I don't what I changed to make it not working again. Though it's fixed now.

ManeraKai avatar Jun 11 '22 08:06 ManeraKai

hopefully it should be working now, I don't what I changed to make it not working again. Though it's fixed now.

so I need to wait for new release?

rezad1393 avatar Jun 17 '22 11:06 rezad1393

yep

ManeraKai avatar Jun 17 '22 15:06 ManeraKai

installed the new version. the bug is still there.

rezad1393 avatar Jun 20 '22 23:06 rezad1393

it seems firefox new version somehow fixed the behavior for youtube to invidious redirect in new tabs (but not for embedded ones) before when I open a youtube link and it got directed to invidious, it would load as 720p non-dash because it would seemed to get a set of cookies from addon that I could not change with unify setting. so refreshing would not change that. only opening a direct invidious link would get the browser cookies from my own saved setting from invidious instance website itself (not the addon)

now I don't know if your addon unify seeing even works or not (I am a bit tired of testing it) but I know that redirect from youtube to invidious tabs would now use the website saved cookies that I have saved with invidious instance setting itself. so I think in the firefox new version your addon cookies that are saved or not, are not even applied anymore (no more 720p non-dash at first redirect)

the issue with embedded video using 720p non-dash and so preloading, is still there.

so the new firefox update (104) seems to actually stop your addon cookies from getting applied to tabs. which would be bad news for you but for me because I just use the redirect m it is good news :))) .

rezad1393 avatar Aug 24 '22 02:08 rezad1393

I understood that invidious doesn't like redirections. Like if you had an iframe that was originally invidious, then it will have that cookie working. However, if it was a youtube link and got redirected, then it would not accept the cookies for security reasons I assume. This was also happening with the normal tabs. This isn't happening with LibReddit for example. I'll close this issue bc Firefox already fixed the tabs so I assume the iframes will be fixed too.

ManeraKai avatar Nov 01 '22 14:11 ManeraKai