libre-tube
Share menu should have a copy link along side piped, YouTube.
Describe your suggested feature
Adding copy link to the share menu will allow users to copy the link without switching app, then users can maybe use floating window to share the copied link.
Other details
No response
Acknowledgements
- [x] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
- [X] I have written a short but informative title.
- [X] I will fill out all of the requested information in this form.
I agree. The share menu in some ROMs doesn't have a copy link option as in my case. I'm having difficulty just copying a video link.
There is a small problem when implementing this feature. Which links are supposed to be copied: YouTube or Piped? This will require a solution.
I use URLCheck app for this purpose...not sure this feature is absolute necessary for LibreTube. With URLCheck you can copy, edit & perform multiple custom actions on it.
Another feature that NewPipe allows is pasting url in search bar and opening that video from link.
I use URLCheck app for this purpose...not sure this feature is absolute necessary for LibreTube. With URLCheck you can copy, edit & perform multiple custom actions on it.
you can't really make a justification for it not being there because copying links is something we do often and needing third party apps to do it is a bad mark on a great app such as this one
New Pipe does that natively. That's why I suggested. It's a feature suggestion, not a rant. :) It's a bad design philosophy(To have an extra app just for a single purpose that can easily be native, maybe I'll contribute :) ). See the difference.
I use URLCheck app for this purpose...not sure this feature is absolute necessary for LibreTube. With URLCheck you can copy, edit & perform multiple custom actions on it.
you can't really make a justification for it not being there because copying links is something we do often and needing third party apps to do it is a bad mark on a great app such as this one
- I think it's more about the way share UI is called.
Okay, in fact https://github.com/libre-tube/LibreTube/blob/aaa9792001415197e12e1b5e96785b0baa95e020/app/src/main/java/com/github/libretube/ui/dialogs/ShareDialog.kt#L76 should "enable" the copy button according to Android's documentation about it. The copy button does appear for me on Stock Android 14, so I'm not really sure why it doesn't work on other Android ROMs / versions.
I'm not really sure why it doesn't work on other Android ROMs / versions
Actually the problem is with some manufacturers who make stupid modifications in the Android share menu.
I suggest a solution is that long pressing the "YouTube" or "Piped" button copies the link of YouTube/Piped.
I think long pressing is not really intuitive - I think a dedicated button would be better, that'll require a small redesign of the share dialog though, but I think that's reasonable.
I suggest a solution is that long pressing the "YouTube" or "Piped" button copies the link of YouTube/Piped.
Then it will be like a hidden feature that most people will never notice. +1 for Bnyro design idea. Dedicated copy buttons for Piped and YouTube separately to the right side aligned with the toggle switch.
I think a dedicated button would be better
sure! I suggested the long presss solution because I assumed that you do not have time for a share menu redesign. But yeah it is reasonable.
What do you guys think of this design? If it looks okay, I can raise PR.
Thanks for the draft @amandeepsinghjamwal I planned to do a larger overhaul of the share dialog and already have some drafts for it, I'll probably work on that when I'm back home next week.
I'm not really sure why it doesn't work on other Android ROMs / versions
Actually the problem is with some manufacturers who make stupid modifications in the Android share menu.
I suggest a solution is that long pressing the "YouTube" or "Piped" button copies the link of YouTube/Piped.
oh. thanks. that's dope. love it. (Isn't functional yet.)
What do you guys think of this design? If it looks okay, I can raise PR.
nice. should I close this issue?
should I close this issue?
No. GitHub issues are closed when already done by a PR.