unix-opts icon indicating copy to clipboard operation
unix-opts copied to clipboard
verified publisher icon libre-man

Dev

Open digikar99 opened this issue 5 years ago • 6 comments

I guess the commits mostly cover all the changes; those that do not seem well mentioned include -

  • travis now checks for both ecl and allegro
  • sionescu fork for travis is a maintained one, with more recent implementation versions; these updates in turn demanded a need for the addons - perhaps, this should be taken care of in the travis script
  • unix-opts-tests is renamed to unix-opts/tests; and (unix-opts/tests:run) runs the tests; there is some test refactoring as well; fiveam, local-nicknames, asdf:test-op are not supported on all implementations (clisp in particular); hence, cannot be used.

I am not sure about the versioning conventions, but the change on adding ambiguous-option condition might be significant enough for some people to demand a version bump.

digikar99 avatar May 23 '20 14:05 digikar99

While I had attempted default, your implementation with the consideration of mutable args is probably better; as well as my implementation is incomplete missing out on a few aspects such as modifying the describe function.

digikar99 avatar May 24 '20 12:05 digikar99

Hi thanks @digikar99 for the extensive fixes!

I will cherry pick/manually extract the features from it one by one if that is ok by you. The first one I've done was improving the testing in #27. In the next few days I'll extract the macro for the shorter definition of the options.

libre-man avatar May 26 '20 21:05 libre-man

Yes that's perfectly okay; if anything, the way it has been done with the recent PR is much better than what I had attempted.

digikar99 avatar May 26 '20 22:05 digikar99

Looks like most of the things have been merged. Two of the things that seem to remain include ambiguous-option and expand-opts. Any opinions about them?

digikar99 avatar Jul 28 '20 12:07 digikar99

I'm still planning on merging them, but I haven't had time for it just yet, also because it needs quite some work to split them up especially as the master now contains some of the functionality already of this PR. I'll probably have some time this weekend to get started on it again, so hopefully I'll be able to merge the expand-opts soon.

libre-man avatar Jul 28 '20 13:07 libre-man

I'd be willing to close this PR - this looks pretty dirty anyways - and perhaps issue a separate PR explicitly for the expand-opts.

digikar99 avatar Jul 28 '20 13:07 digikar99