LibsDisguises icon indicating copy to clipboard operation
LibsDisguises copied to clipboard

Enderman disguises don't automatically hold held block

Open Yahiamice opened this issue 3 years ago • 1 comments

For every other disguise out there that can hold items & blocks (skeleton, villager, fox), holding an item while in that disguise makes that disguise hold the item the disguised player's holding. However, in the case of endermen, if you're holding a block (since items don't work), it's not updated at all and the enderman disguise still appears to be holding nothing.

Doing /disguise Enderman setItemInMainHand %held-item% does fix this however, but shouldn't it be automatic?

Using PaperSpigot 1.16.5, latest ver of protocolib & Libsdisguises 10.0.26 (+dev build?)

Yahiamice avatar Jul 28 '21 03:07 Yahiamice

This one is somewhat tricky as the solution would probably need to be implemented at the packet level when it detects a held item change.

Adding to this, would need to differnate between if the metadata was set by the held item switching or not, and act appropiately.

We don't want it to reflect the player holding stone, only for the plugin to think the stone was set as a command or by a plugin or something and should never be changed by the "current held item" logic. Same for when a saved disguise loads. So a soft "This metadata isn't to be kept, it changes and is default a null" option to speak.

libraryaddict avatar Mar 10 '22 11:03 libraryaddict