rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

feat(quic): added more quic transport config parameters

Open sirandreww-starkware opened this issue 2 months ago • 2 comments

Description

Allow the users of the QUIC transport to control more QUIC configurations when they provide them.

Notes & open questions

  • Defaults change nothing.
  • Updated QUINN version and added QUINN-proto

Change checklist

  • [x] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] A changelog entry has been made in the appropriate crates

sirandreww-starkware avatar Oct 15 '25 12:10 sirandreww-starkware

Thanks for the PR!

This adds a lot of new parameters that are all just quinn TransportConfig. Wdyt of, instead of exposing each parameter separately, we have one function

pub fn with_transport_config<F: Fn(&mut quinn::TransportConfig)>(f: F) 

where users can modify the config directly?

We'd only need to be careful that there is no breaking change in quinn::TransportConfig when we upgrade the dependency. But I think it's easy to add a test for that.

Discussed with @jxs out-of-band. We decided to not expose quinn::TransportConfig so we don't risk breaking our API when quinn::TransportConfig has a breaking change. So the current approach of this PR is fine.

elenaf9 avatar Oct 17 '25 18:10 elenaf9

Where does that leave this PR? what do I need to change for this PR to be approved? I see there is some CHANGELOG issue?

sirandreww-starkware avatar Oct 29 '25 10:10 sirandreww-starkware