Rendezvous: Make `/rendezvous/1.0.0` public

[12TreeMan31]

Description

Change rendezvous::PROTOCOL_IDENT from pub(crate) to pub.

Motivation

Rendezvous should provide its protocol id for consistency with other modules that do the same

Current Implementation

rendezvous::PROTOCOL_IDENT is set to pub(crate)

Are you planning to do it yourself in a pull request?

Yes

[dariusc93]

Hey @12TreeMan31. While I am not against having it public, could you explain what your use case might be to having it public besides consistency? I would have to double check, but I dont believe the rendezvous protocol supports changing its protocol, hence it's being used (and visible) only within the crate itself. The only use case I might see is if one is checking the protocol list from identify and using the identifier from rendezvous instead of their own (though it would not change anytime soon since its that way from spec).

[12TreeMan31]

Hi @dariusc93. Sorry if I was being vague, but I am doing exactly what you describe with identify. The main reason I am doing that is so I can keep track of rendezvous servers I have connected to. While it is easy to just provide the protocol id myself, I noticed that other protocol ids are already provided and I wasn't sure why.

[dariusc93]

Thanks! Well im not against it being public. It would probably make it more consistent across other protocols that have it public as well.