rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

feat(transports/webrtc-websys): Browser to Browser WebRTC

Open elijahhampton opened this issue 8 months ago • 10 comments

Description

Closes #4389 and possibly #5453. WebRTC implementation for browser to browser over relay.

Notes & open questions

Change checklist

  • [x] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] A changelog entry has been made in the appropriate crates

elijahhampton avatar Apr 08 '25 03:04 elijahhampton

This pull request has merge conflicts. Could you please resolve them @elijahhampton? 🙏

mergify[bot] avatar Apr 08 '25 03:04 mergify[bot]

Update to the PR coming soon

elijahhampton avatar Jun 05 '25 22:06 elijahhampton

@dariusc93 @elenaf9 Can I get an initial review on this?

elijahhampton avatar Jun 12 '25 03:06 elijahhampton

Hey @elijahhampton thanks for putting this together. I'm just trying to find some time to take a look at it.

DougAnderson444 avatar Jun 15 '25 01:06 DougAnderson444

Hey @elijahhampton thanks for putting this together. I'm just trying to find some time to take a look at it.

Okay, no worries, thanks

elijahhampton avatar Jun 15 '25 01:06 elijahhampton

@DougAnderson444 happen to get a chance to review? 🙏 (this and another issue blocking some integrations my team has planned)

Faolain avatar Jul 10 '25 08:07 Faolain

Based on examples/browser-to-browser-webrtc and examples/relay-server, I was able to send messages between two browsers. However, when the relay server is shut down, the connection between the browsers is also shut down. Is this the intended behavior?

Fiono11 avatar Jul 25 '25 11:07 Fiono11

@Fiono11 that is unintended, the connection should persist after the signalling server goes offline

DougAnderson444 avatar Jul 25 '25 17:07 DougAnderson444

Based on examples/browser-to-browser-webrtc and examples/relay-server, I was able to send messages between two browsers. However, when the relay server is shut down, the connection between the browsers is also shut down. Is this the intended behavior?

I will take a look at this. Thanks for testing a bit.

elijahhampton avatar Aug 04 '25 11:08 elijahhampton

@Fiono11 Please feel free to try this again. If you manually close the relay server now the WebRTC connection should persist.

elijahhampton avatar Nov 03 '25 03:11 elijahhampton