feat(transports/webrtc-websys): Browser to Browser WebRTC
Description
Closes #4389 and possibly #5453. WebRTC implementation for browser to browser over relay.
Notes & open questions
Change checklist
- [x] I have performed a self-review of my own code
- [x] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] A changelog entry has been made in the appropriate crates
This pull request has merge conflicts. Could you please resolve them @elijahhampton? 🙏
Update to the PR coming soon
@dariusc93 @elenaf9 Can I get an initial review on this?
Hey @elijahhampton thanks for putting this together. I'm just trying to find some time to take a look at it.
Hey @elijahhampton thanks for putting this together. I'm just trying to find some time to take a look at it.
Okay, no worries, thanks
@DougAnderson444 happen to get a chance to review? 🙏 (this and another issue blocking some integrations my team has planned)
Based on examples/browser-to-browser-webrtc and examples/relay-server, I was able to send messages between two browsers. However, when the relay server is shut down, the connection between the browsers is also shut down. Is this the intended behavior?
@Fiono11 that is unintended, the connection should persist after the signalling server goes offline
Based on
examples/browser-to-browser-webrtcandexamples/relay-server, I was able to send messages between two browsers. However, when the relay server is shut down, the connection between the browsers is also shut down. Is this the intended behavior?
I will take a look at this. Thanks for testing a bit.
@Fiono11 Please feel free to try this again. If you manually close the relay server now the WebRTC connection should persist.