rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

fix(webrtc): turn down the webrtc log spam

Open dhuseby opened this issue 9 months ago • 3 comments

Description

This PR changes a couple tracing::error!'s to tracing::warn!'s in the webrtc code so that it won't spam the log so much. The error messages are still available if you run your app with RUST_LOG=warn but if you run with the default error level you will no longer get spammed.

Notes & open questions

Nope.

Change checklist

  • [x] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] A changelog entry has been made in the appropriate crates

Signed-off-by: Dave Grantham [email protected]

dhuseby avatar Mar 31 '25 01:03 dhuseby

@dhuseby if these errors occur very frequent in your logs then it might be an indication of bigger underlying issue. Could you provide some debug-level logs where this error appears?

The function is used in the initial noise handshake, so might be related to #5877.

elenaf9 avatar Apr 03 '25 01:04 elenaf9

@elenaf9 sure, I'll provide more context. I'm getting it a lot in the new universal-connectivity rust peer. It doesn't seem to be related to the network topology for the peer it gets run on. I've run this on my local system, on a public VPS with no firewall, and in my home lab with a firewall that supports UPnP and does seem to work with libp2p's hole punching tricks.

I'll run some tests soon and see if I can identify the source of the error.

dhuseby avatar Apr 21 '25 14:04 dhuseby

can you also try it with the latest master to see if it persists Dave? Thanks

jxs avatar Apr 28 '25 10:04 jxs