rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

feat: deprecate async_std support in DNS crate

Open gitToki opened this issue 9 months ago • 10 comments

ref https://github.com/libp2p/rust-libp2p/issues/5935

crate to update: swarm, mDNS, and the transports TCP, QUIC and DNS.

gitToki avatar Mar 26 '25 09:03 gitToki

@elenaf9 sorry for these

gitToki avatar Apr 17 '25 12:04 gitToki

Hi @elenaf9 - what is the status for removing async-std? I saw this was a blocker for #5968 . I have a dependabot alert for the hickory-proto crate I need to address ASAP. I'm blocked on upgrading my reth dependency until this is updated in rust-libp2p. Is there something I can do to help get this updated?

grantkee avatar May 05 '25 16:05 grantkee

Hi @elenaf9 - what is the status for removing async-std? I saw this was a blocker for #5968 . I have a dependabot alert for the hickory-proto crate I need to address ASAP. I'm blocked on upgrading my reth dependency until this is updated in rust-libp2p. Is there something I can do to help get this updated?

CI is still failing (see below comment), and rustfmt is needed, rest LGTM.

Thank you, @elenaf9 🙏 Hi @gitToki, are you still working on this? Would you like any help?

grantkee avatar May 05 '25 16:05 grantkee

This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏

mergify[bot] avatar May 05 '25 18:05 mergify[bot]

Hi @elenaf9 - what is the status for removing async-std? I saw this was a blocker for #5968 . I have a dependabot alert for the hickory-proto crate I need to address ASAP. I'm blocked on upgrading my reth dependency until this is updated in rust-libp2p. Is there something I can do to help get this updated?

CI is still failing (see below comment), and rustfmt is needed, rest LGTM.

Thank you, @elenaf9 🙏 Hi @gitToki, are you still working on this? Would you like any help?

Yes I am sorry for the delay

gitToki avatar May 07 '25 10:05 gitToki

This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏

mergify[bot] avatar May 18 '25 13:05 mergify[bot]

CI is still failing, can you please take a look @gitToki ?

The test should now work @jxs there are just 2 test that I had to change : identify_external_addr_report and update_address_on_connect in memory_store.rs because of different timing behavior in Tokio's task scheduler and network address format differences.

gitToki avatar May 18 '25 13:05 gitToki

This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏

mergify[bot] avatar May 21 '25 08:05 mergify[bot]

This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏

mergify[bot] avatar Jun 02 '25 21:06 mergify[bot]

Actually waiting for request response / swarm / websocket for dns

gitToki avatar Jun 07 '25 13:06 gitToki

@gitToki is this PR ready from your side?

Edit: actually, CI still fails.

elenaf9 avatar Jun 24 '25 07:06 elenaf9