rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

chore: Fix for Incorrect Object Passing and Loop Control

Open mdqst opened this issue 11 months ago • 0 comments

Description

I noticed a couple of issues in the script:

  1. The function fix_unreachable_pub_warning was receiving m (part of the warning) instead of the full warning object, which caused unexpected behavior. I fixed this by passing the correct object.
  2. The script was using return to exit the loop when the code wasn't in the current workspace. I replaced it with continue to ensure the loop processes all warnings as intended.

Change checklist

  • [x] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] A changelog entry has been made in the appropriate crates

mdqst avatar Jan 21 '25 09:01 mdqst