rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard
verified publisher icon libp2p

Path 1: update rcgen to version 0.12.1

Open haurog opened this issue 1 year ago • 2 comments

As described in https://github.com/libp2p/rust-libp2p/issues/5590 this PR shows all the necessary changes for update path 1. In this solution, only minimal changes are necessary to achieve the goal described in https://github.com/libp2p/rust-libp2p/issues/5590, but libp2p now depends on 2 different versions of rcgen.

Notes & open questions

Change checklist

I did not do the changes described below. I can do this once it is decided which update Path is the one to go.

  • [ ] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] A changelog entry has been made in the appropriate crates

haurog avatar Sep 05 '24 09:09 haurog

Good to hear that other people are interested in getting it to compile on risc-v as well. The two PRs are two different ways to achieve the goal. I named them 'Path 1' and 'Path 2'. I hope the description in https://github.com/libp2p/rust-libp2p/issues/5590 helps in understanding what and why I did it. The main reason for it was that I do not know the code base well enough to judge which approach is more feasible, so I submitted both versions for more experienced people to judge and improve upon.

haurog avatar Sep 05 '24 13:09 haurog

replied on https://github.com/libp2p/rust-libp2p/pull/5592#pullrequestreview-2283205651

jxs avatar Sep 05 '24 14:09 jxs

We have an interest to get rcgen updated to at least 0.12 to enable quic transport on Windows UWP arm64 platform. Ring 0.16 does not compile on it. So I'm willing to do some work for this pr, but would be glad to hear any advice on what is missing to get this in.

mangolas avatar Dec 12 '24 11:12 mangolas

We have an interest to get rcgen updated to at least 0.12 to enable quic transport on Windows UWP arm64 platform. Ring 0.16 does not compile on it. So I'm willing to do some work for this pr, but would be glad to hear any advice on what is missing to get this in.

Based on @jxs comment in https://github.com/libp2p/rust-libp2p/pull/5592#pullrequestreview-2283205651 I believe that it would be preferred to update rcgen directly to v0.13.1. The PR that did that (#5592) was closed, but I think it was only closed under the assumption that @haurog would then solve it in this current PR. (correct me if I am wrong @jxs). So it would be great if you take that over, whether it's in this PR or a new one!

elenaf9 avatar Dec 12 '24 15:12 elenaf9

ok, so working from #5592 and updating to rcgen v0.13.1 seems to be the conclusion. I will give it a try.

mangolas avatar Dec 12 '24 16:12 mangolas

ok, so working from #5592 and updating to rcgen v0.13.1 seems to be the conclusion. I will give it a try.

If you have any questions feel free to ask :)

dariusc93 avatar Dec 12 '24 17:12 dariusc93

Just to update that I still haven't got enough time from higher priority tasks to delve into this.

mangolas avatar Jan 09 '25 15:01 mangolas

turns out to update rcgen one needs to also update webrc so the canonical PR should be #5448 thanks @mangolas for raising it.

jxs avatar Jan 24 '25 16:01 jxs