rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

feat(swarm): improve `PeerAddresses` configurability

Open stormshield-frb opened this issue 1 year ago • 3 comments

Description

Our average peer has over 10 advertised addresses. Doing so, identify was continuously (every 1 minute) emitting ToSwarm::NewExternalAddrOfPeer which was overflowing our logs and was making the PeerCache kind of useless.

For this reason, we made some changes in order to be able to configure the number of addresses that should be cached for a peer. We are upstreaming this changes.

Notes & open questions

N/A

Change checklist

  • [x] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] A changelog entry has been made in the appropriate crates

stormshield-frb avatar Aug 28 '24 14:08 stormshield-frb

This pull request has merge conflicts. Could you please resolve them @stormshield-frb? 🙏

mergify[bot] avatar Sep 05 '24 15:09 mergify[bot]

This pull request has merge conflicts. Could you please resolve them @stormshield-frb? 🙏

mergify[bot] avatar Sep 26 '24 14:09 mergify[bot]

This pull request has merge conflicts. Could you please resolve them @stormshield-frb? 🙏

mergify[bot] avatar Nov 06 '24 12:11 mergify[bot]