rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

deps: deduplicate dependencies

Open onur-ozkan opened this issue 10 months ago • 1 comments

Description

Helps to reduce number of dependencies by removing duplicated ones.

onur-ozkan avatar Apr 17 '24 12:04 onur-ozkan

Hi, and thanks for your interest! As we use dependabot to submit PR's with updates for the dependencies I don't think this is worth it. If we downgrade tempfile dependabot will submit a PR trying to update it afaik, trying to keep track of downgraded packages and keeping ignoring upgrades for certain so that we have less package versions on Cargo.lock is therefore not worth it imho.

Only the 2nd commit downgrades a dependency as pointed out at https://github.com/libp2p/rust-libp2p/pull/5318#discussion_r1568777634. I will revert that commit since the repo has dependabot integration.

onur-ozkan avatar May 08 '24 15:05 onur-ozkan

Ping @jxs for stalled PR

drHuangMHT avatar Jun 01 '24 07:06 drHuangMHT