mergify continously approving approved pull requests

[mxinden]

Summary

Mergify seems to continously approve already approved pull requests. See e.g. https://github.com/libp2p/rust-libp2p/pull/5206.

Expected behavior

Approve once.

Actual behavior

Approve ~ every mintue.

Relevant log output

No response

Possible Solution

No response

Version

No response

Would you like to work on fixing this bug ?

No

[mxinden]

I paused all merge queues, thus far without success.

https://dashboard.mergify.com/github/libp2p/repo/rust-libp2p/queues?branch=master&queues=default

[mxinden]

Potential hot-fix: https://github.com/libp2p/rust-libp2p/pull/5208

[mxinden]

#5208 did the trick. I unpaused the merge queue.

[jxs]

thanks Max, it seems mergify approves but doesn't add the send-it label right? With your hotfix we now need to manually approve the deps PR's from dependabot right?

[mxinden]

thanks Max, it seems mergify approves but doesn't add the send-it label right?

Did it ever? As far as I can tell, it simply enqueues it right away:

https://github.com/libp2p/rust-libp2p/blob/46ec6c416a9b06c089236a8d6d44e55d0c3f7edd/.github/mergify.yml#L36-L42

[mxinden]

With your hotfix we now need to manually approve the deps PR's from dependabot right?

I don't know what the best process is. I don't think the PRs are urgent. Instead I suggest debugging the mergify issue first.