rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

rendezvous: emit `ToSwarm::NewExternalAddrOfPeer`

Open thomaseizinger opened this issue 1 year ago • 4 comments

Description

With https://github.com/libp2p/rust-libp2p/pull/4371 merged, we have the foundation of https://github.com/libp2p/rust-libp2p/issues/4302 implemented.

libp2p-rendezvous needs to be extended to emit this new event whenever it discovers a new address of a peer from a rendezvous point.

Motivation

Other behaviours should be able to learn addresses of peers from the rendezvous behaviour.

Current Implementation

Only the rendezvous behaviours learns the addresses.

Are you planning to do it yourself in a pull request ?

No

thomaseizinger avatar Jan 21 '24 06:01 thomaseizinger

Once the PR is merge (its not merged as of this comment) i can tackle this and the other later this week if nobody else have by then

dariusc93 avatar Jan 24 '24 03:01 dariusc93

Yeah I am not sure what is going on with CI at the moment.

thomaseizinger avatar Jan 24 '24 04:01 thomaseizinger

I see it was merged so ill would like to tackle this one (will do the other one in a separate pr if nobody else wish to do it)

dariusc93 avatar Jan 25 '24 23:01 dariusc93

I see it was merged so ill would like to tackle this one (will do the other one in a separate pr if nobody else wish to do it)

Somebody is working on mDNS and kad.

thomaseizinger avatar Jan 26 '24 00:01 thomaseizinger