rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard

kad: emit `ToSwarm::NewExternalAddrOfPeer`

Open thomaseizinger opened this issue 1 year ago • 11 comments

Description

With https://github.com/libp2p/rust-libp2p/pull/4371 merged, we have the foundation of https://github.com/libp2p/rust-libp2p/issues/4302 implemented.

libp2p-kad needs to be extended to emit this new event whenever it discovers a new address through the DHT.

Motivation

Other behaviours should be able to learn the addresses discovered by kademlia.

Current Implementation

Only kademlia knows about its discovered addresses.

Are you planning to do it yourself in a pull request ?

No

thomaseizinger avatar Jan 21 '24 06:01 thomaseizinger

would like to work on this

1010adigupta avatar Jan 25 '24 23:01 1010adigupta

would work on mDNS and DHT simultaneously, you can assign me this as well

1010adigupta avatar Jan 25 '24 23:01 1010adigupta

would work on mDNS and DHT simultaneously, you can assign me this as well

Make them two PRs please! :)

thomaseizinger avatar Jan 26 '24 00:01 thomaseizinger

unsure whether this one is taken but seem prev one has made such claim and not submit pattern in some other repo couple times..

justcode740 avatar Feb 19 '24 06:02 justcode740

You are welcome to work on this too!

thomaseizinger avatar Feb 19 '24 06:02 thomaseizinger

Hi, do you mind if I try to do this?

I know a little bit of Rust, but this is my first time contributing to a p2p related library, so if you don't mind, is there any code or documentation that would help me solve this issue?

blacktoast avatar Apr 19 '24 14:04 blacktoast

@blacktoast are you still interested in tackling this issue?

dariusc93 avatar May 19 '24 04:05 dariusc93

Hi guys, I saw that this ticket was stale for some time so I gave it a try at #5549 . Let me know what you think 🙂

PanGan21 avatar Aug 11 '24 10:08 PanGan21