rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard
verified publisher icon libp2p

fix(kad): close progress whenever closer in range

Open maqi opened this issue 2 years ago • 4 comments

Closer shall be calculated as closer to the seen num_results peers, not just to be being the closest as current.

This is in parallel to the PR https://github.com/libp2p/rust-libp2p/pull/4932 Split them into two to make the work easier to be discussed and reviewed.

Description

Notes & open questions

Change checklist

  • [x] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] A changelog entry has been made in the appropriate crates

maqi avatar Nov 27 '23 14:11 maqi

This pull request has merge conflicts. Could you please resolve them @maqi? 🙏

mergify[bot] avatar Dec 01 '23 18:12 mergify[bot]

This pull request has merge conflicts. Could you please resolve them @maqi? 🙏

PR is updated, sorry for the delay

maqi avatar Dec 05 '23 13:12 maqi

Hi, @mxinden ,

here is the follow up fix in parallel to the PR https://github.com/libp2p/rust-libp2p/pull/4932

let me know if it make sense. thx

maqi avatar Dec 05 '23 13:12 maqi

This pull request has merge conflicts. Could you please resolve them @maqi? 🙏

mergify[bot] avatar Feb 19 '24 06:02 mergify[bot]

Hi, @guillaumemichel ,

Really appreciate your comments and suggestions.

Sorry for the late reply, have not check back this crate for a while as had been a while not receive any feedback.

Thx again and hope this PR could be merged soon.

Best Regards,

maqi avatar Apr 03 '24 06:04 maqi

The failing clippy as at https://github.com/libp2p/rust-libp2p/actions/runs/8534098889/job/23377901550?pr=4934 seems not related to this PR ?

maqi avatar Apr 03 '24 06:04 maqi